Merged
Conversation
AntSimi
requested changes
Apr 6, 2021
src/py_eddy_tracker/dataset/grid.py
Outdated
| if wave_length < min_wave_length: | ||
| logger.error( | ||
| "Wave_length too short for resolution, must be > %d km", | ||
| "Wavelength too short for resolution, must be > %d km", |
Owner
There was a problem hiding this comment.
In this case we talked about variable which are called "wave_length", i don't know the best soltuion
src/py_eddy_tracker/dataset/grid.py
Outdated
| def kernel_lanczos(self, lat, wave_length, order=1): | ||
| """Not really operational | ||
| wave_length in km | ||
| wavelength in km |
Owner
There was a problem hiding this comment.
n this case we talked about variable which are called "wave_length", i don't know the best soltuion
src/py_eddy_tracker/dataset/grid.py
Outdated
|
|
||
| def kernel_bessel(self, lat, wave_length, order=1): | ||
| """wave_length in km | ||
| """wavelength in km |
Owner
There was a problem hiding this comment.
n this case we talked about variable which are called "wave_length", i don't know the best soltuion, maybe add docstring for argument like :
:param float wave_length: in km
|
|
||
| # FIXME : we want to change | ||
| # segment A splits from segment B, then x days after segment B merges with A | ||
| # to |
Owner
There was a problem hiding this comment.
maybe create a project note or an issue for improvement, about that
|
|
||
| def remove_trash(self): | ||
| """ | ||
| Remove the lonely eddies (only 1 obs in segment, associated segment number is 0)""" |
Owner
There was a problem hiding this comment.
i don't think black allow """" on same line?
| :param None,list(str) remove_vars: List of variable name which will be not loaded | ||
| :param None,list(str) include_vars: If defined only this variable will be loaded | ||
| :param None,dict indexs: Indexs to laad only a slice of data | ||
| :param None,dict indexs: Indexs to laod only a slice of data |
AntSimi
reviewed
Apr 7, 2021
AntSimi
approved these changes
Apr 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.